Description
The dashboard sync has failed since the GitSync hub moved from the user account to the m7kni organisation. The workflow checks out and pushes m7kni/gc-gitsync-m7kni, but scripts/verify-gitsync.py still searches Grafana provisioning resources for the old repository URL, so verification aborts before checking the live dashboards. This is a local verifier defect, not a shared-workflow release issue.
Acceptance Criteria
- #1 The verifier locates the same GitSync repository URL that the workflow checks out and pushes
- #2 A focused regression test fails for the stale owner URL and passes for the corrected canonical URL
- #3 The Grafana sync workflow completes and verifies both live dashboards after the fix is pushed
- #4 just check and a completed CodeRabbit review pass
Definition of Done
- #1 just check
- #2 just gen (if any generated artifact changed) and the diff committed
Implementation Plan
Add a focused unit test around repository selection, centralize or correct the canonical GitSync URL without changing deployment authority, run targeted and full gates, review, push, and verify the new workflow run.
Implementation Notes
Wave 4 lane-zero diagnosis: run 33804484167 failed because find_repository searched for the old rknightion URL while the same workflow checked out and pushed the m7kni repository. gh release list confirms v1.18.1 is still the latest shared-workflow release, but grafana-sync is a local workflow and this failure is unrelated to a reusable pin.
Test-first evidence: before correcting the URL, both focused tests failed against the stale rknightion owner. After correction, python3 -m unittest scripts/verify_gitsync_test.py -q passed 2/2. Two source-only CodeRabbit passes completed with zero findings across justfile, scripts/verify-gitsync.py, and scripts/verify_gitsync_test.py. just gen completed with no generated drift; full just check passed, including 427 Grafana tests and no called vulnerabilities. Live workflow verification remains pending the pushed commit.
Live acceptance evidence: grafana-sync run 33805731939 completed success at source SHA 47abc590. GitSync reached the pushed revision with state=success after 20s, then the verifier reported both opnsense-exporter and opnsense-exporter-health matched and all dashboards verified live. The rules job reported 80 resources pushed with 0 errors.
Final Summary
Corrected the local Grafana GitSync verifier to use the same organisation-owned repository as the workflow and added a regression test tying the verifier URL to the workflow checkout. Verified by two completed zero-finding CodeRabbit passes, just gen, full just check, and grafana-sync run 33805731939, which confirmed both dashboards live.