Description
Wave 3 found that limiter resolution is tested only with an artificial parent chain. A production collector or subcollector can lose parent or limiter wiring and fail only on its first live API call.
Acceptance Criteria
- #1 The test inventory discovers every production facade_for owner
- #2 Each production ownership chain resolves a non-null limiter before a live API call
- #3 Any deliberate exception is enumerated and justified in the test
Definition of Done
- #1 just check (ruff format –check, ruff check, mypy, generated-doc drift, offline API conformance, and the marker-filtered pytest run with the 80% coverage floor — this is exactly what the CI
testjob runs) - #2 just gen, when metrics, config, endpoints, collectors, the settings schema or the chart config changed —
just checkincludes the drift gate and CI fails the build on it - #3 Grafana queries in grafana/dashboards/*.json and grafana/alerts/ updated, if a metric or label name changed
Implementation Plan
Wave 2 L4 phase 2 after MDE-0037: add a failing production facade-owner inventory test, construct each owner family, prove every non-exempt ownership chain resolves a limiter, enumerate justified exceptions, and run focused checks.
Implementation Notes
Wave 3 established that the current contract test covers only an artificial owner chain. Enumerating and constructing every production owner needs a dedicated mapping pass.
Wave 2 red: production_facade_owner_inventory_is_complete failed with NameError before the inventory helper existed. The completed inventory discovers 46 production facade owners across five construction families; every constructed chain resolved a supplied limiter and executed its fake SDK call only through the facade, with no deliberate limiter exceptions. Focused gate: 50 passed; just check: 2913 passed, 5 deselected, 91.22% coverage.
Final Summary
Parked after audit. Resume by generating a complete facade_for owner inventory, defining construction fixtures for each owner family, and proving every non-exempt chain resolves a limiter.
Wave 2: added a complete production facade-owner inventory and construction-family contract proving all 46 owners resolve a limiter before SDK execution; there are no deliberate exceptions. Verified by focused tests and just check.